GateNLP / gate-lf-pytorch-json

PyTorch wrapper for the LearningFramework GATE plugin
Apache License 2.0
1 stars 2 forks source link

Check use of ngrams with chunking! #44

Closed johann-petrak closed 5 years ago

johann-petrak commented 5 years ago

This probably does not work and should maybe just get documented as not working for now.

However we have code in the modelwrapperdefault, we should re-assess how that actually works.

johann-petrak commented 5 years ago

OK, this shows the error "Sequences/ngrams within sequences of feature vectors are not supported" from the python-data backend. So, the code in the modelwrapperdefault is completely useless since the python-data backend already refuses to handle that kind of data! Removed the code and added a comment about this.