Create class hierarchy for AnnotationSet - Githubissues

GateNLP / python-gatenlp

Python text processing, pattern matching, and NLP framework

https://gatenlp.github.io/python-gatenlp/

Apache License 2.0

63 stars 8 forks source link

Create class hierarchy for AnnotationSet #151

Open johann-petrak opened 3 years ago

johann-petrak commented 3 years ago

Consider:

AnnotationSet is an abstract base class
DetachedAnnotationSet is the class used for detached sets
AttachedAnnotationSet is the class used for in-document sets

We could just use the API we have now for AnnotationSet for both, but ideally refactor:

anything related to logging is only in AttachedSet
constructor only possible for DetachedSet

Advantages:

easier to see with print etc. what set we are dealing with
clearer what each type of set can do
can be used with type hinting to document which methods return which sets