GateNLP / semeval2023-multilingual-news-detection

0 stars 0 forks source link

Code not running as it is for st1 due to missing data file creation and wrong file paths #2

Open ameliesc opened 4 weeks ago

ameliesc commented 4 weeks ago

Currently it is not possible to run this code as there are several bugs.

  1. train.py does not work in sst1 for both adapters and transformers as datafiles are loaded which do not exist and are not created anywhere:

https://github.com/GateNLP/semeval2023-multilingual-news-detection/blob/9dab6180ae3a24d08759d9a2c9944bf2d2bc8941/st1/adapters/train.py#L45

https://github.com/GateNLP/semeval2023-multilingual-news-detection/blob/9dab6180ae3a24d08759d9a2c9944bf2d2bc8941/st1/adapters/train.py#L46

https://github.com/GateNLP/semeval2023-multilingual-news-detection/blob/9dab6180ae3a24d08759d9a2c9944bf2d2bc8941/st1/fft/fft_st1.py#L48

https://github.com/GateNLP/semeval2023-multilingual-news-detection/blob/9dab6180ae3a24d08759d9a2c9944bf2d2bc8941/st1/fft/fft_st1.py#L51

...

  1. Readme filepath is wrong.

The ReadME for st1 suggest to extract files into../data/articles/external_satire but process_external_satire.py refers to ../data/external_satire https://github.com/GateNLP/semeval2023-multilingual-news-detection/blob/9dab6180ae3a24d08759d9a2c9944bf2d2bc8941/st1/process_external_satire.py#L19

I suggest cloning this repo and trying to run train.py with the instructions given here.

freddyheppell commented 4 weeks ago

Hi, thanks for bringing these issues to our attention.

For now, as far as I remember:

But we’ll confirm all that and add the missing code as soon as we can.