search

GateNLP / ultimate-sitemap-parser

Ultimate Website Sitemap Parser
https://mediacloud.org/
Other
181 stars 64 forks source link

Optional typing should be set to None for considering as Optional Argument #15

Closed jayanthchandra closed 5 years ago

jayanthchandra commented 5 years ago

I noticed that for RequestsWebClientResponse constructor the Optional Argument is not set as None which would cause an issue in later stages when making new development/fixes around that.

https://github.com/berkmancenter/mediacloud-ultimate_sitemap_parser/blob/3c2b076f52ca57412791a21a6cac4210b3468b86/usp/web_client/requests_client.py#L22

This is not an issue, just a suggestion for keeping it clean :)

pypt commented 5 years ago

Thanks, fixed!