search

GatherPress / gatherpress

Powering our community's event management needs.
https://wordpress.org/plugins/gatherpress/
GNU General Public License v2.0
82 stars 28 forks source link

Remove all public-facing icons #631

Open carstingaxion opened 5 months ago

carstingaxion commented 5 months ago

Describe your question

As much as I appreciate the subtle Icons next to the event date, the address or the online event link, but I have to suggest, to remove all of them, unfortunately.

While working on all the new block-variations I had to remove them one by one, as I came through the blocks, because I would had have to create render_block and blockEdit filters for each icon as block variations don’t support those kind of extra-markup out of the box.

Additionally I think not providing any frontend icons would allow GatherPress to be compatible with more themes which could provide their own icon sets.

Don’t get me wrong, I like icons. And I do like the used dashicons. So maybe we could provide some nice screenshots using the Icon Block Plugin from Nick Diego. Accompanied by some explanation, that Icons might be theme-territory and a link to the Icon plugin.

Alternatively we could make use of emoji within our provided default texts or at least highlight this possibility and a code example within the README. I tested this within my interactive Add-to-calendar exploration.

Bildschirmfoto vom 2024-03-17 16-13-44

EDIT: 01.04.2024

I totally forgot to mention the almost 60kb GatherPress is loading on every frontend-request, this is huge and disproportionately high compared to the 3-4 icons a user might, maybe see. You can see this expensive call in the screenshot, too.

Code of Conduct

nilovelez commented 5 months ago

These are the icons that are used now:

This is what I propose:

carstingaxion commented 5 months ago

Thanks for the nice overview @nilovelez

  • video, clock and calendar: these are de only ones that might be needed to provide visual clues and a consistent user experience. They can be embedded into a custom-base64encoded font (I can do it ). It will reduce the payload to something around 2Kb

Sound like a very good idea. We just need to find a consistent, editable or, in other words, user-friendly way to add the icons to the editor and the frontend. ;-)

  • dashicons-nametag: this can be loaded as an independent .svg file. It is only used in the backend.

I think we don't need to do anything about the nametag icon. Because only the backend uses it, can't we just rely on the dashicons that are loaded by default by core?

  • location, phone and web. Those are unnecessary. The associated text is quite obvious.

Absolutely. 100%. No additions.

carstingaxion commented 4 months ago

find a consistent, editable or, in other words, user-friendly way to add the icons

Just recently I took a deep dive into the experimentation theme by Justin Tadlock, the former WP Tavern author, now writing for the developer blog on .org, where he uses block-styles for that purpose.

In the theme are multiple blocks using this block-style technic to prepend an icon.

https://github.com/x3p0-dev/x3p0-ideas

This might be a good path to take, for us too.

carstingaxion commented 2 months ago
  • They can be embedded into a custom-base64encoded font (I can do it ).

@nilovelez I'm now at the point, where it would be nice to make use of the icon font you suggested. For the new Add-to-calendar block, I created a variant with an (ugly, old demo) icon using a block-style, which seems to be the easiest and most user-friendly way to add icons to blocks.

grafik

You can test the block within the GatherPress Block Playground

But no stress. I'm out for family holiday until the 09. of july. But in 2 weeks, I'd like to finish the new Add-to-calendar block with a nice icon. Could you prepare the font, please @nilovelez ?

nilovelez commented 2 months ago

Ok, I'll prepare a base64-encoded font with the video, clock and calendar icons

El lun, 24 jun 2024 a las 0:49, Carsten Bach @.***>) escribió:

  • They can be embedded into a custom-base64encoded font (I can do it ).

@nilovelez https://github.com/nilovelez I'm now at the point, where it would be nice to make use of the icon font you suggested. For the new Add-to-calendar block, I created a variant with an (ugly, old demo) icon using a block-style, which seems to be the easiest and most user-friendly way to add icons to blocks.

grafik.png (view on web) https://github.com/GatherPress/gatherpress/assets/198883/58678108-9109-4ee7-9cb9-84c6b6533862

But no stress. I'm out for family holiday until the 09. of july. But in 2 weeks, I'd like to finish the new Add-to-calendar block with a nice icon. Could you prepare the font, please @nilovelez https://github.com/nilovelez ?

— Reply to this email directly, view it on GitHub https://github.com/GatherPress/gatherpress/issues/631#issuecomment-2185347515, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMLOMBUIVVQSBOEN2ANA3DZI5GHHAVCNFSM6AAAAABFQEJOQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBVGM2DONJRGU . You are receiving this because you were mentioned.Message ID: @.***>

mauteri commented 2 months ago

Left this in Slack, but going to leave it here too.

Let's hold off for now on creating any new icons based on feedback from accessibility call. I think we may take the advice to remove the icons, but I want to bring it to discussion and not just have it as one person's opinion, even if the icons end up different and are no longer affecting accessibility. I still want designs to look good.

MervinHernandez commented 2 months ago

Agree with Mike. Let's keep this in backlog for now.

carstingaxion commented 2 months ago

Let's hold off for now on creating any new icons based on feedback from accessibility call. I think we may take the advice to remove the icons, but I want to bring it to discussion and not just have it as one person's opinion, even if the icons end up different and are no longer affecting accessibility.

Until here I can follow and also agree: Let's remove all public icons.

I still want designs to look good.

But here I become uncomfortable with my interpretation. Keep or remove, what did you actually mean @mauteri ?

(Btw. I'd love to read the accessibility feedback GatherPress got.)

mauteri commented 2 months ago

@carstingaxion Mervin is currently getting the feedback into issues for us to review. Mostly what I was saying on this is folks we spoke to about accessibility mentioned removing the icons on our blocks, there was discussion here about doing it differently, and I just want to punt the conversation to later and not execute on anything concerning icons with blocks until we discuss it a bit further.

carstingaxion commented 2 months ago

Ok, thank you for your fast response @mauteri !