GatherPress / gatherpress

Powering our community's event management needs.
https://wordpress.org/plugins/gatherpress/
GNU General Public License v2.0
94 stars 30 forks source link

Breaks register_taxonomy_for_object_type #946

Open shawfactor opened 1 week ago

shawfactor commented 1 week ago

Describe the bug

The plugin currently breaks the register_taxonomy_for_object_type, it is likely causing other problems as well.

Basically if I do

register_taxonomy_for_object_type( 'category', 'page', 100000 );

The category taxonomies functionality does not work properly, The taxonomy appears in the menu but not in the list table (it is not in screen options) and an error occurs in the block editor. See screenshots of both attached.

This occurs on a blank instll so its not a conflict with another plugin.

The issue is something to do with the settings functionality as if I comment out lines 124 and 139 in class-base.php then the issue goes away (but then the settings don't work). Can this be fixed urgently please?

no_category_colum error

Steps to Reproduce

Install on blank installation use register_taxonomy_for_object_type View the post type listing and try to edit the applicable post type

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress information

No response

Code of Conduct

carstingaxion commented 1 week ago

Hello @shawfactor ,

let me know please, which WP and GatherPress versions you’re running?

From the outside, the base settings class and the registration of taxonomies per post type does not have much in common. Also interesting is, that you’re able to fix it by disabling the base settings, which hasn’t been touched in 7 months.

At first, let’s see how to make this reproduceable!

  1. What does the browser console say, when the error appears?
  2. Can you provide a Playground link with the setup you described?