Closed wh201906 closed 11 months ago
qt5-base is not enough for developing the GUI, it might just work for just compiling, but future GUI changes might require additional qt5 modules.
But we don't use any other qt5 package except qt5-base
in the Linux installation instructions
https://github.com/RfidResearchGroup/proxmark3/blob/16d078369cbaa213f741f605495493c364f4bbfa/doc/md/Installation_Instructions/Linux-Installation-Instructions.md#on-debian--ubuntu--kali--parrotos--raspbian https://github.com/Proxmark/proxmark3/wiki/Ubuntu-Linux#setup-and-build-for-ubuntu
If the GUI requires more packages in the future, these installation instructions will be changed. And we can add the new packages in the ProxSpace. Plus, if these unnecessary packages are removed, the users will save a lot of time and space when installing or updating the ProxSpace. Could you please reconsider removing these non-essential Qt5 packages?
Here is the size comparison
Last time I checked the installation instructions had the full qt5 package. I'll have to look into it.
I did switch to the qt5-base package, as well as adding some missing packages. Thank you for telling me that the full qt5 package was no longer needed.
Most of the packages in
mingw-w64-x86_64-qt5
are unnecessary. The simple GUI in the Proxmark3 only requires qt5-base. Plus, some unused packages inmingw-w64-x86_64-qt5
cost a lot of time to install.