codecov-io
commented
4 years ago Codecov Report
Merging #76 into master will decrease coverage by
7.70%. The diff coverage is29.41%.
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
- Coverage 71.94% 64.23% -7.71%
==========================================
Files 2 2
Lines 139 137 -2
Branches 23 24 +1
==========================================
- Hits 100 88 -12
- Misses 36 46 +10
Partials 3 3 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/data_collection.py | 62.29% <29.41%> (-8.68%) |
:arrow_down: |
This pull request refactors the data collection module to work with two json files, one for storing the raw data, and the other for storing the calculated metrics. It also adds functions that directly retrieve/calculate data and writes it on the appropriate json file. It uses optional parameters to facilitate testing while allowing for default parameters. Please let me know if additional changes are needed. All necessary checks are passing and test cases have been modified to work with this change.