Closed noorbuchi closed 4 years ago
Merging #77 into master will decrease coverage by
3.09%
. The diff coverage is21.87%
.
@@ Coverage Diff @@
## master #77 +/- ##
==========================================
- Coverage 64.23% 61.14% -3.10%
==========================================
Files 2 2
Lines 137 175 +38
Branches 24 32 +8
==========================================
+ Hits 88 107 +19
- Misses 46 64 +18
- Partials 3 4 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/data_collection.py | 59.37% <21.87%> (-2.93%) |
:arrow_down: |
Merging #77 into master will not change coverage by
%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #77 +/- ##
=======================================
Coverage 64.77% 64.77%
=======================================
Files 2 2
Lines 176 176
Branches 32 32
=======================================
Hits 114 114
Misses 61 61
Partials 1 1
I recognize the concern with test cases and decreasing coverage, I'm currently working on adding more test cases that will make coverage much better.
For reviewers that have not made a review here, it would be useful to get in depth feedback on this work! 😎
This PR makes changes to the individual metrics stored data by adding the data collected using PyGitHub such as issues commented, issues opened, PRs opened, PR commented. It also adds many new test cases that ensure all the functions are working properly. This is a work in progress but I'm hoping to get this merged as soon as possible to meet the deadline. More test cases are still needed and I'm working on doing that. Please let me know of any changes you feel are necessary. Thanks for your feedback!