search

GatorCogitate / cogitate_tool

Tool to analyze contributions when working in a team.
5 stars 13 forks source link

Update Pipfile #92

Closed cklima616 closed 4 years ago

cklima616 commented 4 years ago

Added validators package to Pipfile to fix name error.

santacruzm commented 4 years ago

Great work I am approving these changes.

noorbuchi commented 4 years ago

@JMilamber I agree that it's odd that it didn't come up until now. I think that we should try to replicate this issue before merging this pull request or maybe see if someone other than @carmop has encountered it. It could be the case that team members that worked on the CLI did not encounter it because they had the dependency installed locally and the error didn't show up. How do you think we should go about solving this?

JMilamber commented 4 years ago

@noorbuchi I think we first need to know some more specifics from @carmop about what system he's on, what branch he was checked into, what commands he ran to set the pipenv up, and what commands he used to run the program that created this error. And then see if we can find someone with the same operating system who can replicate it. Right now, besides adding it to the pipfile, we don't know much about how this could have been caused so i agree with you that we need to replicate the bug before we change anything. I was looking into python's libraries, and they do say that different distributions of Python may come with different extra Modules (outside of the one that always come with python) and that Pedro may have one that didn't have 'validators' packaged with it but those of us working on the CLI do? Just a thought, like I said above we need more info from him on how to recreate this bug before we can merge this.

JMilamber commented 4 years ago

@carmop sorry to tag you so much, but since the error is potentially fixed here, could you undo the changes you made to your local pipfile by re-pulling from the master branch and try to re-create the bug yourself? And to let us know the specifics mentioned above?

carmop commented 4 years ago

@JMilamber So, I tried again. I re-cloned the repo and I tried to run it but got the same error: name " name 'validators' not defined ". I do not have validators installed locally which some of you might have and I think it might be what causes me to not be able to run the program straight after cloning it while you guys can.

carmop commented 4 years ago

Here are the details requested: OS: Ubuntu Branch: Masters Commands ran: pipenv install --dev, pipenv python run src/cogitate.py -t mytoken -r GatorCogitate/cogitate_tool -l https://github.com/GatorCogitate/cogitate_tool -rm n

JMilamber commented 4 years ago

@JMilamber So, I tried again. I re-cloned the repo and I tried to run it but got the same error: name " name 'validators' not defined ". I do not have validators installed locally which some of you might have and I think it might be what causes me to not be able to run the program straight after cloning it while you guys can.

@carmop thanks for replicating the issue. I uninstalled "validators" locally from my computer and tried running cogitate with the same command you used (pipenv run python -t mytoken -r GatorCogitate/cogitate_tool -l https://github.com/GatorCogitate/cogitate_tool -rm n), for me the program still ran. @noorbuchi @cklima616 I think at this point its most likely a distribution difference, or a OS difference and this shouldn't break the build so it should be merged.

noorbuchi commented 4 years ago

The program still ran on my end even after uninstalling the dependency but it's better to include the package in the Pipfile. We can merge this PR since we got all the needed approvals.

noorbuchi commented 4 years ago

Unless there are any new suggestions or change requests, let's plan to get this PR merged today. Please feel free to comment your questions or requests for change here.