Added Testing Coverage - Githubissues

GatorEducator / execexam

:rocket: ExecExam runs executable examinations that assess Python programming skills

2 stars 3 forks source link

Added Testing Coverage #12

Closed rebekahrudd closed 3 weeks ago

rebekahrudd commented 2 months ago

This feature adds the command to run pytest and coverage. It also lowers the passing threshold of the test coverage to 50% so the build continues to pass while we run tests going forward

boulais01 commented 1 month ago

Hello @rebekahrudd, I'd like to recommend converting this PR to a draft for now on account of the unresolved comment and the failing build. If the failing build is expected, I also recommend specifying that in the PR description. Thank you!

gkapfham commented 1 month ago

Hello @rebekahrudd, can you please:

Resolve the print statement in the code
Convert the PR to a draft until you are finished with the final version

@CalebKendra and @boulais01 thanks for the feedback, I agree with all the points you shared!

rebekahrudd commented 1 month ago

That print line has actually been deleted in the fork we are using as a class. Here is the commit message where it was deleted: https://github.com/PCain02/execexam/commit/2093d054ef343423cba522e772e6f394ff0d4e28. Is it possible to add that commit to this PR?

PCain02 commented 1 month ago

That print line has actually been deleted in the fork we are using as a class. Here is the commit message where it was deleted: PCain02@2093d05. Is it possible to add that commit to this PR?

You should be able to sync your branch with the main branch with the sync button. Then deal with any merge conflicts and go from there. Hope this helps.

gkapfham commented 1 month ago

@hannahb09 can you please give us an update on whether or not you are going to be able to repair the build that continues to break for this pull request?

gkapfham commented 3 weeks ago

Hello @rebekahrudd, this PR has conflicts with specific files. Please also note that there are at least two other PRs that are all related to this one, at least in the name. As such, the other members of our team are not going to be clear as to which one should be merged first (or at all). Can you please investigate these issues and then report back?

gkapfham commented 3 weeks ago

Hello @rebekahrudd can we close this PR? Or, do you intend to push it forward in the future?

rebekahrudd commented 3 weeks ago

We can close this PR