Removed hard coding of "rrobin" and replaced with constant variables

GatorIncubator / gatorgrouper

:busts_in_silhouette: Automated Group Formation Tool Enabling Effective Team Work

GNU General Public License v3.0

20 stars 20 forks source link

Removed hard coding of "rrobin" and replaced with constant variables #176

Closed baldeosinghm closed 5 years ago

baldeosinghm commented 5 years ago

Removal of hard coding of "rrobin" for constant variable

This pull request will remove any hard coding of the string "rrobin" in all of gatorgrouper. Gatorgrouper now uses global.py, a file containing constant variable that hold the string "rrobin".

Fixes #113

Type of Change: Hard Coding Removal

Please describe the pull request as one of the following:

[ ] Bug fix
[ ] Breaking change
[ ] New feature
[ ] Documentation update
[x] Other (Please specify any helpful information below)

Changed hard coding of string "rrobin" and instead used constant variable ALGORITHM_ROUND_ROBIN from globals.py.

Tags

Matthew Baldeosingh

Michionlion commented 5 years ago

There's now a merge conflict, but it looks good otherwise.

@baldeosinghm If you merge master into your branch (with the Resolve conflicts button on Github), and everything looks the same, then I'll merge this since it has the required reviews.

Michionlion commented 5 years ago

@baldeosinghm Just some minor linting issues to fix -- the undefined variable is likely because you need to add defaults. to the variable so that you reference the imported module:

gatorgrouper/globals.py:1:0: C0111: Missing module docstring (missing-docstring)
gatorgrouper/utils/gatorgrouper.py:43:38: E0602: Undefined variable 'DEFAULT_NUMGRP' (undefined-variable)
gatorgrouper/utils/gatorgrouper.py:50:42: E0602: Undefined variable 'DEFAULT_NUMGRP' (undefined-variable)

baldeosinghm commented 5 years ago

Fixed all necessary changes and merge conflict