GatorIncubator / gatorgrouper

:busts_in_silhouette: Automated Group Formation Tool Enabling Effective Team Work
GNU General Public License v3.0
20 stars 20 forks source link

Moving the issue_template.md to the docs folder to increase code cov #189

Closed thomad74 closed 5 years ago

thomad74 commented 5 years ago

Description of Pull Request

Moving the file for the issue template to the correct folder (docs) to try and fix problems regarding code coverage. Also renamed the issueTemplate.md to issue_template.md to match the conventions of the pull_request_template.md file in the same folder.

Fixes #183

Type of Change

Please describe the pull request as one of the following:

Tags

@Lancasterwu

codecov[bot] commented 5 years ago

Codecov Report

Merging #189 into master will decrease coverage by 31.42%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #189       +/-   ##
===========================================
- Coverage   99.12%   67.69%   -31.43%     
===========================================
  Files           9        8        -1     
  Lines         228      226        -2     
===========================================
- Hits          226      153       -73     
- Misses          2       73       +71
Impacted Files Coverage Δ
gatorgrouper/utils/read_student_file.py 27.77% <0%> (-72.23%) :arrow_down:
gatorgrouper/utils/group_rrobin.py 56.36% <0%> (-43.64%) :arrow_down:
gatorgrouper/utils/group_random.py 60% <0%> (-40%) :arrow_down:
gatorgrouper/utils/parse_arguments.py 76.47% <0%> (-19.69%) :arrow_down:
gatorgrouper/utils/display.py 81.81% <0%> (-18.19%) :arrow_down:
gatorgrouper/utils/constants.py

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 204bb40...bf0bcd3. Read the comment docs.

thomad74 commented 5 years ago

Should this be in the hidden .git folder? I am not seeing a .github folder anywhere in the master branch.

Michionlion commented 5 years ago

Should this be in the hidden .git folder? I am not seeing a .github folder anywhere in the master branch.

No, the .git folder is not put on github. If the .github folder does not exist, you can create it. It is likely that the PR template should also be moved, and the Logo PR #155 also needs to be changed since the docs folder will be unused.

thomad74 commented 5 years ago

Okay, I just created a .github folder and moved the issue_template.md and the pull_request_template.md file into it. I also deleted the docs folder as @Lancasterwu said it will be unused now.