search

GatorIncubator / gatorgrouper

:busts_in_silhouette: Automated Group Formation Tool Enabling Effective Team Work
GNU General Public License v3.0
20 stars 20 forks source link

Without `--num-group`, Using `--graph` Would Run Wrong Method `group_random` #266

Closed Lancasterwu closed 5 years ago

Lancasterwu commented 5 years ago

@Michionlion It was there already, we didn't refactor it since it only uses numgroup.

elif (
            GG_ARGUMENTS.method == constants.ALGORITHM_GRAPH
            and GG_ARGUMENTS.num_group is not constants.DEFAULT_NUMGRP
        ):
            GROUPED_STUDENT_IDENTIFIERS = group_graph.group_graph_partition(
                SHUFFLED_STUDENT_IDENTIFIERS, GG_ARGUMENTS.num_group
            )

However, there was a bug that if we don't use --num-group with --graph and only use --graph the program will run group_random. We can fix that bug with a different PR or just in PR#261.

Originally posted by @Lancasterwu in https://github.com/GatorEducator/gatorgrouper/pull/260#issuecomment-472910446