search

GatorIncubator / gatorgrouper

:busts_in_silhouette: Automated Group Formation Tool Enabling Effective Team Work
GNU General Public License v3.0
20 stars 20 forks source link

QuickFix/skipped valid form test in `test_forms.py` #281

Closed enpuyou closed 5 years ago

enpuyou commented 5 years ago

Description of Pull Request

Fixes #280

Type of Change

Please describe the pull request as one of the following:

Tags

@enpuyou

sutterj commented 5 years ago

@enpuyou Is there a reason why it got changed from entering two passwords to one? Does the form also check to see that they match or was it there initially in error?

enpuyou commented 5 years ago

@enpuyou Is there a reason why it got changed from entering two passwords to one? Does the form also check to see that they match or was it like initially in error?

It was two passwords because in CustomUserCreationForm, the form checks if two password matches. And when I wrote the test case, I thought CustomUserChangeForm works in the same way so I assumed that it needs two passwords in there as well. I believe it should not have passed in the first place. And since I did not run pipenv install, pytest didn't catch that error.