search

GatsbyCentral / gatsby-awesome-pagination

An opinionated, more awesome approach to pagination in Gatsby
MIT License
110 stars 27 forks source link

Update README.md #19

Closed kpennell closed 4 years ago

chmac commented 5 years ago

@kpennell Thanks for the PR.

What’s the motivation behind this change? Does the import ... syntax not work in the default Gatsby setup? Do you know if something has changed there, or did this never work?

I’m not opposed to merging your PR, just wondering what the motivation is behind it. I’m assuming the import ... syntax used to work, but maybe I’m wrong there.

kpennell commented 5 years ago

Didn't work for me

On Sun, Aug 11, 2019, 2:48 PM Callum Macdonald notifications@github.com wrote:

@kpennell https://github.com/kpennell Thanks for the PR.

What’s the motivation behind this change? Does the import ... syntax not work in the default Gatsby setup? Do you know if something has changed there, or did this never work?

I’m not opposed to merging your PR, just wondering what the motivation is behind it. I’m assuming the import ... syntax used to work, but maybe I’m wrong there.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GatsbyCentral/gatsby-awesome-pagination/pull/19?email_source=notifications&email_token=AAIC4IOWL7OE3RKHVNOMNJ3QEADABA5CNFSM4IKVT6GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4BAIVI#issuecomment-520225877, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIC4IMS7ROOFRDEV73KIPLQEADABANCNFSM4IKVT6GA .

chmac commented 5 years ago

@kpennell What starter were you using? The default starter uses import... syntax, so I assume it usually works. We could add a second example that adds the require ... syntax as well, maybe that’s the best solution, what do you think?

chmac commented 4 years ago

Closing this assuming it's no longer active, feel free to reopen if I misunderstood...