search

Gaulomatic / AirPodsSanity

Fixes the Sound Quality of AirPods when connected to a Mac.
110 stars 7 forks source link

Credit @milgra in README.md #6

Closed habovh closed 4 months ago

habovh commented 4 months ago

Even though @milgra's AirPods Sound Quality Fixer's license does not require any attribution, I think it is fair to give credit where credit is due, especially within this also open-source project.

Sadly it isn't a proper fork so it's a bit difficult to highlight differences/improvements between the two projects, and it makes it harder for wannabe contributors to decide which project is the "active" one, avoiding duplicate issues such as #2 and #3. But I digress.

In any case, great work from both of you @milgra & @Gaulomatic!

Gaulomatic commented 4 months ago

Just for clarification: The inspiration for this indeed came from @migra's project, but none of the code. AirPods Sound Quality Fixer simply didn't work for me on my Mac for some unknown reason.

Since I am mentally challenged when it comes to ObjectiveC, I implemented the functionality from scratch using Swift and my own (maybe sub-optimal) ideas about how to get there. This is really just a personal project, a way to get in touch with Swift.

I will merge your PR since I think it is fair to clarify the origin of the idea.

habovh commented 4 months ago

Thanks for the clarification! I actually found @milgra's project first, but a few quirks made me look for an alternative solution, that's when I found yours. And since the icons are seemed to be identical —I couldn't figure out which icon was which app—, it got me wondering whether this project was a fork.

I genuinely believed that this project used @milgra's code at some point, hence the wording on my PR. I believe this PR doesn't do justice to your work, and I'm glad to see that you updated the credit to inspired by!

Apologies for the confusion, and kudos on the full rewrite in Swift!