search

GaurangTandon / ProKeys

free Chrome/Opera extension; makes you productive in online text-related work
Other
101 stars 32 forks source link

Extension shouldn't die if anything goes wrong on the options page. #281

Closed GaurangTandon closed 5 years ago

GaurangTandon commented 5 years ago

This is a frightening experience for any new user:

If I right click the extension's icon on my toolbar and go to "options" it takes me to a page that just shows "Version: - Gaurang Tandon, Varun Singh © 2018", and if I click any of the options on the side menu (snippets, settings, help, about) nothing happens. I really need access to my snippets and don't want to uninstall and reinstall the extension and have to recreate them,

Ideally extension shouldn't die on any simple error. Rather, all basic features should load as far as they can, and a simple popup should describe what the error is.

GaurangTandon commented 5 years ago

Dies on reloading too. Ideally, reloading the ext shouldn't change anything.
No repro since 3.5.2 update.

GaurangTandon commented 5 years ago

fixed in https://github.com/GaurangTandon/ProKeys/commit/f87e6ee418daec6feb291d71c41c3ca939712449