GaurangTandon / codeforces-darktheme

A dark theme built for Codeforces
MIT License
121 stars 34 forks source link

<ins> tag color in code compare window is too bright #29

Closed user202729 closed 4 years ago

user202729 commented 4 years ago
<ins style="background:#80ff80;overflow-wrap:break-word;"
<del style="background:#ff8080;overflow-wrap:break-word;"

White/yellow text are unreadable on light green colors.

Possible CSS selector:

div.diffHtmlTarget pre.prettyprint ins[style^="background:#80ff80"] {
    background: #?????? !important;
}

div.diffHtmlTarget pre.prettyprint del[style^="background:#ff8080"] {
    background: #?????? !important;
}
GaurangTandon commented 4 years ago

Thanks for the report! :) I have changed it to this now, I agree previously it was too bright.

image

I have manually checked all individual tokens satisfy at least AA readability constraints.

New colors:

  1. Deletion: #7b1313
  2. Insertion: #004600
  3. Red tokens inside insertion area: #ff9d9d