Gauravwagh / django-grappelli

Automatically exported from code.google.com/p/django-grappelli
Other
0 stars 0 forks source link

Missing object-tools-items block in change_form.html #387

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Which DJANGO-VERSION are you using?

1.3

Which GRAPPELLI-VERSION are you using?

2.3.3

Which BROWSER (including the version) are you using?

Google Chrome 12.

What steps will reproduce the problem?

Override the change_view template adding one ore more object tools in the 
object-tools-items block, such as:
{% block object-tools-items %}
  {% if object_id %}
    <li><a href="/fatture/{{ object_id }}/print" target="_blank">{% trans "Print" %}</a></li>
  {% endif %}
  {{ block.super }}
{% endblock object-tools-items %}

What is the expected output? What do you see instead?

In plain django the new button is displayed near to "History"; with Grappelli 
it's not.

Please provide any additional information below.

Grappelli is duplicating the {% object-tools %} implementation in django, which 
makes it prone to getting out of date. This causes the reported problem and 
it's also not applying classes "historylink" and "viewsitelink" to default 
links. AFAIU at the very least it should add back the object-tools-items block.

Original issue reported on code.google.com by nando.dessena on 10 Jul 2011 at 1:27

GoogleCodeExporter commented 9 years ago
added block object-tools-items in r1453.

please note that the link-classes (historylink, viewsitelink) are different 
with grappelli. the mentioned classes are way to explicit and not reusable in 
our opinion (we use "focus" instead).

Original comment by sehmaschine on 17 Jul 2011 at 2:44