search

Gavant / glint-template-types

MIT License
19 stars 20 forks source link

Why are we not using default exports? #6

Closed wagenet closed 3 years ago

wagenet commented 3 years ago

Since each has its own file, why have:

import { FaIconComponent } from '@gavant/glint-template-types/types/@fortawesome/ember-fontawesome/fa-icon';

and not

import FaIconComponent from '@gavant/glint-template-types/types/@fortawesome/ember-fontawesome/fa-icon';
bakerac4 commented 3 years ago

The main reason I use named exports as a pattern is to make it easily discoverable in VScode for autocompletion. But we could also use both or switch because Im not particularly tied to a certain direction for this package

wagenet commented 3 years ago

Just realized I may have broken things in the ember-render-modifiers change. I'll submit a fix soon. Just don't release until I do :)

bakerac4 commented 3 years ago

Haha, no problem. I'll probably wait to release until you add everything you want to anyways 😄

wagenet commented 3 years ago

@bakerac4 if you do export default Foo then VSCode picks it up as Foo.