margin used by .gk-article when no Article Info

[Ruud68]

Hi, when displaying article info, like auhor and category,

is created and te information is put in there. .gk-article has a margin set of '0 0 56px 116px', this to accomodate the Article Info on the side.

I have a bunch of articles that do not have any article info enabled, so the

is not created but... the margin of .gk-article is still set to '0 0 56px 116px' leaving my page with abondunt white space on the side... for my desktop browsing this is ókay but on a tablet that is a waste of space :(

How can I get the following use cases;

1. article info displayed > .gk-article margin = '0 0 56px 116px'
2. no article info displayed > .gk-article margin = '0'

below two screenshots depicting the situation (first is current situation with margin, second is preferred situation):

[dziudek]

Added to the list of bugfixes for the next release.

[Ruud68]

Hi, not a developer but thought I give it a shot:

This is what I did: in ./meetgavern/html/com_content/article/default.php I added the following logic:

set variable:

$aside = False

where 'aside' is created I set $aside=True like this

    <aside>
        <?php $aside = True; ?>
        <?php if ($params->get('show_publish_date')) : ?>   
        ...

and then I add some logic:

    <?php if ($aside==True): ?>
        <?php echo '<div class="gk-article">'; ?>
    <?php else : ?>
        <?php echo '<div class="gk-article-noaside">'; ?>
    <?php endif; ?>

in joomla.less I add:

.gk-article-noaside { font-size: 1.1@baseBodyFontSize; line-height: 2@baseBodyFontSize !important; margin: 0; }

Now for the good part.... this works :) these changes should then also be added to ./meet_gavern/html/com_content/featured/default_item.php ./meet_gavern/html/com_content/category/blog_item.php

If this makes sence from a developer point of view I can complete the fix and create a pull request for it... please advise

[dziudek]

Your idea is ok, but I'll use my solution which will be more consistent with the template code :)

[Ruud68]

okay, looking forward to it :)

[dziudek]

Added: https://github.com/GavickPro/Meet-Gavern/commit/0eca167a7b33fe9929f444214fffda03391f0680

[Ruud68]

Hi, thanks for this fix. implemented it on my test site and I am struggling to get it to work correctly. I have set all article options to hide (global options), I have a menu item that displays a single article. In this menu item I toggle the options, but I cannot find the logic for which one triggers the display of aside.

As I understand it from the code it should toggle on the value of $aside_visible (being e.g. show_publish_date = visible or show_category = visible)

When setting everything to hide except show_publish_date it doesn't show. additionally setting show_modify_date to show it will show, but this is not correct is it?

Can you tell me which values should be set to visible in order to display the aside?

[dziudek]

That's weird, but I've removed brackets and I've changed or to ||: https://github.com/GavickPro/Meet-Gavern/commit/fa81653c0442eb49794aeb95593710ae69733605

Now it should work fine.

[Ruud68]

Hi @dziudek I can confirm that this is now fixed! thanks for working on it :) regards, Ruud.