search

GavickPro / Meet-Gavern

Meet Gavern Template for Joomla! 3.0
42 stars 41 forks source link

Update default.php #258

Closed Ruud68 closed 8 years ago

Ruud68 commented 8 years ago

Just found out that this commit: https://github.com/GavickPro/Meet-Gavern/commit/57d475cc746672702f72c8311c67f37daa3633f2 breaks og:image functionality. This commit fixes that :) Please see me with any questions

-> og_image should be set otherwise required og:image will be left empty -> $this->item->text is the text AFTER rendering of all other plugins etc. This results in the wrong image being taken (on my site it takes the author avatar that is placed above a blog) instead of the article text first image. I changed that to $this->item->introtext . $this->item->fulltext to only use the actual article text -> Facebook requires an image that is larger then 200px. If the selected image is smaller than we have the fall back to use a fallback image (set in the templates back-end). This was disabled > my change enables that again.

dziudek commented 8 years ago

Thanks for this code :)

Ruud68 commented 8 years ago

You are welcome :) Was unable to to a PR due to my repo being out of sync and me not knowing how to do a cherry picked PR. Glad it also worked this way :)