search

GavickPro / Meet-Gavern

Meet Gavern Template for Joomla! 3.0
42 stars 41 forks source link

Notices in featured view #259

Open Ruud68 opened 8 years ago

Ruud68 commented 8 years ago

Hi, I get the following notices:

Notice: Trying to get property of non-object in /var/www/html/test/templates/meet_gavern/html/com_content/featured/default.php on line 23
Notice: Trying to get property of non-object in /var/www/html/test/templates/meet_gavern/html/com_content/featured/default.php on line 24

I have looked at the code and the lines are below:

// Create shortcuts to some parameters.
$params         = $this->item->params;
$images     = json_decode($this->item->images);

Both the $params and $images are NOT used in that file. It is save to just remove them?

dziudek commented 8 years ago

Hello,

Yes, you can remove these lines as they are used and duplicated in the default_item.php file: https://github.com/GavickPro/Meet-Gavern/blob/master/meet_gavern/html/com_content/featured/default_item.php#L13-L14