GavickPro / Meet-GavernWP

Meet GavernWP is a responsive free Wordpress theme
35 stars 23 forks source link

Typography: lists are not working correctly #136

Closed erura closed 11 years ago

erura commented 11 years ago

When I use list for example:

[ulist style="2"] item1 item2 item3 [/ulist]

it shows me items in one line:

item1 item2 item3

but should be in three lines:

item1 item2 item3

dziudek commented 11 years ago

Hi,

I've checked this shortcode and it is working fine for me. Did you used it inside the post/page? Because the selectors for this shortcode becomes with "article" so it will work only inside the posts/pages.

erura commented 11 years ago

Please have a look here: http://wordpress-joomla.pl/test

dziudek commented 11 years ago

Very strange - are you using the latest version of the theme? I'm interested especially in fact if you have in the function gavern_ts_ulist this line:

$lines = preg_split( '/\r\n|\r|\n/', $content );

(file gavern/helpers/helpers.shortcodes.php)

erura commented 11 years ago

I'm using the latest version of the theme 1.5.1 on WP 3.5. I didn't change anything in this file so it is strange for me too. Should I remove this line?

dziudek commented 11 years ago

no, this line is very important, but also the used regexp is very important - if it is:

/\r\n|\r|\n/

then it is very interesting, why you are getting one line, instead of few lines, because it should detect all types of newline chars. Please try replace this regexp to:

/\r\n|\n\r|\r|\n/
erura commented 11 years ago

Unfortunately the list items are still in one line.

dziudek commented 11 years ago

And how it is displayed in the WP Editor? As one line or it was merged into one line?

erura commented 11 years ago

[ulist style="1"] item1 item2 item3 [/ulist]

dziudek commented 11 years ago

Sorry but in this case you will have to use the normal HTML code till I won't find a reason of the problem, currently I've no idea what can cause it, because as I wrote earlier, on my installation it is working fine.

erura commented 11 years ago

OK. Thank you for your time!

dziudek commented 11 years ago

Not replicable