search

GavickPro / Meet-GavernWP

Meet GavernWP is a responsive free Wordpress theme
35 stars 23 forks source link

Breadcrumbs display not properly #212

Closed Fiskaperdana closed 11 years ago

Fiskaperdana commented 11 years ago

Hi MeetGavernWP developer,

I did't know after i update again with MeetGavernWP 1.7 from github yesterday, why breadcrumbs display not properly? Before the breadcrumbs display fine.

You can look the picture bellow: display wrong

I am sorry before. I report you to many issue. Thanks before.

note: on search page, on tag page work fine

dziudek commented 11 years ago

Fixed: https://github.com/GavickPro/Meet-GavernWP/commit/6e3014d014f3e52207a6218a652a0c8cc657a5d1 :)

Fiskaperdana commented 11 years ago

@dziudek i am sorry.Now in category page work fine. But in single page or normal page, browser still not show me breadcrumbs. only show Home (should Home/Your page). Can you see your code again? thanks before.

dziudek commented 11 years ago

@Fiskaperdana - you're right - fixed here: https://github.com/GavickPro/Meet-GavernWP/commit/a6024745b6bdba22ce41c482b79e0eef3bc31182 :) Now all should be OK :)

Fiskaperdana commented 11 years ago

@dziudek
Oke. I will check it all.

Fiskaperdana commented 11 years ago

@dziudek I think you forget one line

elseif (is_page()) { 
            // output the page name
            $output .= get_the_title('<span class="gk-current">', '</span>');

should 

elseif (is_page()) { 
            // output the page name
            $output .= '<span class="gk-current">' . get_the_title() . '</span>';

please check line 370-372

dziudek commented 11 years ago

Right - I've also optimized the code more using is_singular(), because the attachment code was the same as code for is_page and is_single :) https://github.com/GavickPro/Meet-GavernWP/commit/e6447c5bd380533151a42e6fc8d514d79a9cf172