search

GavickPro / Meet-GavernWP

Meet GavernWP is a responsive free Wordpress theme
35 stars 23 forks source link

Use Font Awesome instead of glyphicons #215

Closed dziudek closed 11 years ago

dziudek commented 11 years ago

We will get bigger amount of available icons, additionaly it will be retina-ready.

dziudek commented 11 years ago

Added: https://github.com/GavickPro/Meet-GavernWP/commit/7b89d9d0446f31508b539d816bb4d56b69a12f17

ckubs commented 11 years ago

God bless you for adding glyphicons. One small question, If I have my theme in two variants light and dark I can change the colour of those by CSS or ...?

dziudek commented 11 years ago

The Font Awesome icons are like normal text, so you can change the color of these icons using the color property :)

ckubs commented 11 years ago

Asked you before actuall testing and I have one question if I'm not rude. This is the actuall implementation of Font Awesome or the preparation only and I have to add appropriate font-icons myself? As far as I see glyphicons are still present.

dziudek commented 11 years ago

@ckubs - are you looking for the proper branch? In the GavernWP v.1.7 branch there is no glyphicons ;)

ckubs commented 11 years ago

Updated 1.7 files after font awesome adding ... and my post formats icons are still showing with glyphicons. Or the update is meant to affect other parts of the template?

dziudek commented 11 years ago

Post format uses different icons - glyphicons was used for the icons inside the widget titels.

ckubs commented 11 years ago

Ah ok, so I have to implement those myself to completelly remove aditional icons. Can you tell me in what theme file post format stuff with icons is called? I know I have to wrap them in some <i class=

dziudek commented 11 years ago

I recomment to edit section 7.7 in css/stuff.css and use the :before pseudoelement ;)

ckubs commented 11 years ago

No luck but thanks for the tip! Now I know what I have to look for :)

ckubs commented 11 years ago

Ok I've done it with a visual hack. Since text-indent: -9999px; affected both the text and the :before and without it It didn't looked good with both the icon and for example the text chat, or video beside it I gave the font icon a size and the text 0px size. Have to check in some browsers and hope is all ok :)