Closed ckubs closed 11 years ago
I'll add an option to replace Social API with custom code and hooks.
Good, since default buttons appear in a good position, instead of having to modify the template to delete their hook from there and replace it with something else, would be a better feature to not have them at all and replace their settings, in the admin, with only a field where we can imput our custom sharing code/ plugin hook.
And on social tab section you can add also various social settings like those for the upcoming twitter cards, and please one to imput a default image for facebook opengraph to be used if the post shared trough facebook has none.
I've checked all now and:
1) User have available the gavern_social_api filter so it is possible to add own social buttons to the Social API section
2) It is possible to disable the Social API using option: "Include/Exclude specified articles from Social API" and set it to "Disable on all pages"
3) Problem with Open Graph default image was solved here: https://github.com/GavickPro/Meet-GavernWP/commit/bb7735d4d4669e2c3ac9f3ee19274755872b9e81
Yes it's possible to dissable it but since it's an useless piece of code It had been better to have the option to put our own codes or plugin shortcodes in the admin for atlast one reason. To be triggered from the admin right there without having to edit any of theme files as it looks like a good spot for sharing.
No it isn't better - normal user won't search for the FB/twitter/g+ button codes. If somebody wants more then there are filters for it.
Ok, I wont insist. Or atlast you should use a script like Sharrre to have template specifig design for sharing buttons. One of the templates I have in the waiting list to use it has that http://themify.me/themes/pinboard Or another nice implementation I saw on Themeskingdom here http://demo.themeskingdom.com/bloggap/mauris-et-leo-at-orci-rutrum-eleifend-eu-sed-lectus-llentesque/
You have included in Gavern framework the most popular social sharing buttons.
Since they have nothing special(design wise atlast they are default ones provided by twitter, facebook, pinterest) and add some extra load to the code, wouldn't be an option to remove all that? And have in the admin's Social API tab only an field(aka custom footer content) where the user to imput his own sharing code/plugin hook as they are a lot of good sharing plugins out there(Shareaholic for example) and probably some additional setut stuff to things like opengraph or the upcoming twitter cards?