As discussed in title options topic

[NormanUK]

Need to re-create language .pot file please.

[dziudek]

I cannot merge this pull request:

• too much changes in the one commit: for every problem there should be separated commit: one for changes in the contact page code, one for the new options and one for changes in the seo
• the code is not consistient with the framework code - you have removed action hooks and you have used the structural code, you should extend the base of the metabox code used in gavern_show_og_meta_box() function
• there are two metaboxes for SEO options instead of one
• the method of storage of the parameters is bad - all params should be stored in one post meta value as JSON object to limit amount of key-value pairs stored in the database

[NormanUK]

1. I ll try break them down and I ll open separate issue topic highlighting them.
2. / 3. Original Seo meta boxes was 2 and didn't see nor notice they were using gavern_show_og_meta_box function.
3. I ll check that out.

See you around ;)

[dziudek]

2) My mistake - I've local version with one meta box for it - so please in your next revision merge it to one metabox. Regarding the code in gavern_show_og_meta_box - it is a code for more complex metaboxes, and I suggest to use this one, because it contains support for the image field type.

In general when you finish I'll review your code in your fork and then (after my changes) we will merge it, because it is a very important part of the framework and we cannot mess it ;)

[dziudek]

Please remember that we have a little bit of time, because these features will be implemented in Gavern 1.5 which will be released at the start of October :)

[NormanUK]

@dziudek , can you take a look at this class http://www.farinspace.com/wpalchemy-metabox/

Covers pretty much everything including storage mode, normal or json array. Perhaps we can use that.

[dziudek]

@NormanUK - please don't include complex code like this - the JSON storage is too simple operation - it needs usage of two built-in functions - json_decode and json_encode.

[NormanUK]

Problem I am getting is saving fields and retrieving them in save data function while checking old / new values while using json. I think I am going to leave this one to you @dziudek so it doesn't cause anymore delays.

[dziudek]

@NormanUK - ok Mate - I'll work with it on your branch, when I'll start the 1.5 version work :)