search

GavickPro / Portfolio-Free-Ghost-Theme

Simple portfolio theme for Ghost
MIT License
126 stars 39 forks source link

Menu #5

Closed s0eren closed 9 years ago

s0eren commented 9 years ago

Hi there, thanks for your great work! I was wondering if there is any possibility to highlight the current active site in the menu instead of highlighting "Index" all the time?

dziudek commented 9 years ago

Hello,

Unfortunately as far as I know, currently it is not possible in Ghost :/

s0eren commented 9 years ago

Too bad, thanks for the fast reply!

unwitting commented 9 years ago

See my pull request above - this is certainly possible with a little on-load JS :) You'll want to give it a tweak before merging probably, to get the menuPaths generated from template maybe, but that's the essential idea.

s0eren commented 9 years ago

Thanks for the hit! I'll give that a trial!

unwitting commented 9 years ago

@dziudek if you're not willing to implement the JS-based solution, I would suggest removing the class around the first element of the menu - given that it's only appropriate on one page, I think it would be cleaner not to highlight any members of the menu.

unwitting commented 9 years ago

@s0eren let me know if you get good results!

dziudek commented 9 years ago

@unwitting - every user can remove this highlight very easily during editing the menu block.

unwitting commented 9 years ago

You could save them the effort :) I certainly removed it from mine but can't really imagine wanting to keep it around since it's misleading.