GavickPro / Weather

4 stars 9 forks source link

Weather Module Causes Random site Crash with Gantry 5 #28

Open TGoodrich opened 8 years ago

TGoodrich commented 8 years ago

I had been using the GK Weather module for about a year with no issues up until Yahoo changed their api. After the api change I was only getting question marks for weather data. I found a solution in the GK forums, applied the fix and all was good.

I then saw the developer had updated the module due to the api change. I applied the update and then found the weather was not updating.

I also found the module would randomly cause my website to crash and display an error from Gantry 5.

I could not get a specific error saying the module was at fault and only found it was the weather module's fault by disabling all modules and enabling one by one until error returned.

I'm not sure if it will help but here is the error I would receive when the module was faulting:

"Error displaying the error page: An exception has been thrown during the rendering of a template ("Fatal DOM Error 76: Opening and ending tag mismatch: HR line 13 and BODY while parsing: ") in "@nucleus/page_head.html.twig" at line 14.: An exception has been thrown during the rendering of a template ("Fatal DOM Error 76: Opening and ending tag mismatch: HR line 13 and BODY while parsing: ") in "@nucleus/page_head.html.twig" at line 14."

The error does not look related to the weather module but as I said disabling said module stops the error from occurring.

As I mentioned the error would occur randomly. I think it may have something to do with the modules forecast change causing a change in the code output. Gantry 5 will error out and not render website if it detects missing, incomplete or incorrect html tags.

dziudek commented 8 years ago

It seems to be a yahoo api issues: https://github.com/GavickPro/Weather/issues/27#issuecomment-210872165

dziudek commented 8 years ago

Please read: https://github.com/GavickPro/Weather/issues/27#issuecomment-211543295