search

GavinJoyce / ember-component-inbound-actions

Send actions to Ember.js components
MIT License
65 stars 15 forks source link

Update install instructions in README #13

Closed brandonparsons closed 8 years ago

GavinJoyce commented 8 years ago

Thanks, I've just added one small suggestion

brandonparsons commented 8 years ago

@GavinJoyce hmmm - I specifically put that as --save-dev as it is customary for Ember add ons to go into devDependencies. Your thoughts?

GavinJoyce commented 8 years ago

@brandonparsons I believe that we should use --save as this is a run time dependency for an app, not a build time dependency. https://ozthegreat.io/wordpress/stop-using-npm-wrong-save-dev

brandonparsons commented 8 years ago

@GavinJoyce The majority of ember addons use devDependencies, probably because ember cil is responsible for packaging the runtime files from the addons. I'm certainly not that knowledgable on this front however.

For example - note that the ember install command from ember cli uses --save-dev: https://github.com/ember-cli/ember-cli/blob/master/lib/commands/install-npm.js#L19

GavinJoyce commented 8 years ago

@brandonparsons TIL, thanks for the explanation. Perhaps we should use ember install?

GavinJoyce commented 8 years ago

oh, it's being removed too. merging, thanks

brandonparsons commented 8 years ago

np :)