search

GavinJoyce / ember-headlessui

https://gavinjoyce.github.io/ember-headlessui/
Other
92 stars 34 forks source link

Template lint errors in test files #97

Open roomman opened 3 years ago

roomman commented 3 years ago

I'm adding some <Menu> tests and I am seeing ember-template-lint(prettier) errors in VSCode, wherever a template is rendered into a test file:

Screenshot 2021-10-04 at 10 18 52

Assuming others are not seeing these errors(?), and it's an issue with my editor's setup rather than the lint config, what extension are others using for formatting code in VSCode? Hopefully if I mirror, the problem will go away 🤞🏻

GavinJoyce commented 3 years ago

I'm seeing this too in my setup. It seems that it wants us to format is as follows:

Screenshot 2021-10-04 at 11 53 47
GavinJoyce commented 3 years ago

^ It's not terrible, but not necessarily better than what we have. I can see how this will become annoying.

I don't have a strong opinion, but I wouldn't be against disabling prettier for hbs in tests if we can't improve the experience

alexlafroscia commented 3 years ago

That's interesting... it specifically wants the code block aligned do that the first HBS line is all the way at the first column of the file?

I don't see this in my linting set up, which runs Prettier directly on HBS files, so I'm curious what tool specifically is causing this warning