search

Gaweph / p5-typescript-starter

Base starter project using p5js and typescript
MIT License
344 stars 173 forks source link

Replace createCanvas() with resizeCanvas() for smoother resizing #12

Closed JulesFouchy closed 4 years ago

JulesFouchy commented 4 years ago

Thanks a lot, this template is exactly what I was looking for ! ❤️ Figured I could contribute back 🙂

Gaweph commented 4 years ago

Brilliant catch I meant to do resizeCanvas and not createCanvas.

I think you might have accidentaly made a pull request with all of your other changes also. I'm happy to merge a pull request with just the last commit "Replace createCanvas() with resizeCanvas() for smoother resizing" if you want to do one 👍

JulesFouchy commented 4 years ago

Brilliant catch I meant to do resizeCanvas and not createCanvas.

I think you might have accidentaly made a pull request with all of your other changes also. I'm happy to merge a pull request with just the last commit "Replace createCanvas() with resizeCanvas() for smoother resizing" if you want to do one 👍

Oh yes indeed you're right (first time I make a pull request x')) I'm making a clean one ^^