Gaya / queryloader2

Version of the QueryLoader by Gaya Kessler. Preload images with ease.
http://blog.gaya.ninja/articles/queryloader2-preload-your-images-with-ease/
MIT License
718 stars 231 forks source link

Compatibility issue with CloudFlare's 'Rocket Loader' – ? #135

Closed jonasskafte closed 9 years ago

jonasskafte commented 9 years ago

Hi there,

Firstly, well done for having developed a brilliant script! I highly appreciate it, so thanks.

I am not entirely sure if I'm on the right track here as I am not actually a developer myself, however, I recently started using CloudFlare for one of my websites and turned on the 'Rocket Loader' function (https://www.cloudflare.com/features-optimizer), which sounded like a really good idea. However, about a day later I experienced that the site wouldn't show my content (although the site appeared as if it was fully loaded; it was basically just a white page on which I could scroll up and down)?! After examining the issue I realised that the site would work again if I turned off either the Rocket Loader or the QueryLoader2 script, which makes me think that there's potentially a compatibility issue. Could I be right in that? And if so, do you think this is something that can be fixed or should I just live with one or the other?

Thanks,

Jonas

jonasskafte commented 9 years ago

UPDATE The problem might actually be with CloudFlare's Rocket Loader alone, which seems to be pretty harsh on all scripts. I'll send them a bug note now. I'll keep you update here if I hear anything back.

Gaya commented 9 years ago

Thanks for the extensive bug report. Really appreciate it when people take the time to explain the problem.

I can't really tell what Rocket Loader is doing since I have not dug into it yet. The script might change a few things so mine won't work. Let me know if they have an answer, if not: I can look into this.

jonasskafte commented 9 years ago

Hi Gaya,

No problem – thanks for the wonderful script! :-)

Unfortunately I've had no luck in my end. Here's what the CloudFlare support team replied:

Thanks for contacting CloudFlare support.

Unfortunately it seems as if you'll need to choose whether you'll want to use Rocketloader or that 3rd party script.

Best Regards,

Anyway, it might not be worth for you to look into as Rocketloader seems to be quite incompatible in general, but of course, if it's something you'd be keen on fixing anyway, then that would be great – and highly appreciated (sorry I cannot help myself; my coding skills unfortunately doesn't reach that far I am afraid).

For now I've simply just deactivated the Rocketloader as I felt that it was more important to have QueryLoader2 running.

Thanks for listening and responding to my message.

Best,

Jonas

Gaya commented 9 years ago

I've decided not to fix this since it's probably way too much work to go into this for a compatibility issue. Thanks for digging into this so much @jonasskafte

jonasskafte commented 9 years ago

Hi Gaya,

Fair enough and thanks for letting me/us know.

Keep up the good work and thanks for a brilliant contribution to the WP community!

Best,

Jonas