Gazler / githug

Git your game on!
MIT License
6.86k stars 1.03k forks source link

Answer of rename_commit is confusing #255

Closed vikrant-pune closed 4 years ago

vikrant-pune commented 5 years ago

Hi,

We have problem statement as 'Correct the typo in the message of your first (non-root) commit.' I'm assuming this points to second log "First coommit" entry from bellow list with typo:

`~/githug-test/git_hug$ git log 
commit 5ae6bca7768104998ac8aaa93d40ad6f42b3dd90 (HEAD -> master)
Author: vikrant pawar
Date:   Sat Feb 16 20:30:15 2019 +0530

Second commit

commit f877b1e0aa22ed94907de7d06d3b2c470581bb32
Author: vikrant pawar
Date:   Sat Feb 16 20:30:15 2019 +0530

First coommit

commit f03505f0316ea3eae2eaa8533bd044a79883fd8f
Author: vikrant pawar 
Date:   Sat Feb 16 20:30:15 2019 +0530

Initial commit

However even after fixing it, code doesn't mark it as success .. While digging code I found we are using repo.commits[1].message == "First commit" which is checking string 'Second commit' to 'First commit'.

wanted to confirm if I'm missing anything

BreakBB commented 5 years ago

I had no problems with this level. What I did was:

gchazot commented 4 years ago

Same as #258

gchazot commented 4 years ago

Fix in #276

Gazler commented 4 years ago

Fixed in #276