Closed nbehrnd closed 6 months ago
This looks good. I was initially curious as to why this wasn't in repo.init
or init_from_level
but it looks like it doesn't always apply at the start of the level setup.
By the way, for the stage_lines level, you want to use git add -p
:)
«Hunk editing» is a thing I'm not yet confident in; thus the particular note to have the corresponding quiz be checked by someone who is.
One incentive for me to see githug
working regardless of the entry of ~.gitignore
file is that is serves like a test pad to memorize git
. A bit like Anki flash cards, but with the advantage that one can issue other commands prior/after «the real command» the quiz is after to monitor the state and change of the git repository. This is more than «only» check e.g., if one knows the equivalent of for instance English «blue» as French «bleu» while learning a natural language.
Eventually, the slight modification by the lines of git branch -m master
would allow to mark a couple of issues filed as resolved, and submit a new version to rubygems (including an explicit entry about the MIT license of the project, as suggested in PR #346).
grit which currently is used as interface between Ruby and grit is stated as no longer maintained (ref). A transition to libgit2/rugged (entry on rubygems) hence might be a next leap to consider for the over next version of githug i.e., 0.7.0. An increased visibility of githug
in general as well as attracting help for this transition could be achieved for instance if it were packaged for Debian. As I did this for syntax checker markdownlint (relevant thread), were you be comfortable if a) I would do this after your release of githug
0.6.0 to rubygems while indicating b) you as the upstream-contact
to Debian?
I haven't forgotten about this btw. It looks good, I just need to confirm about the push level. I think it should be fine just looking at the code and tests, but need to double check.
The work wasn't done in a single session (there are a few commits to adjust the same .rb file again a couple of days later once again, too). Backed by this experience, I easily understand the review will take some time.
Thanks so much for this <3
@Gazler Where deemed suitable, I added a line
system "git branch -m master"
and lightly edited the description of the tasks in levels 2 up and including 55. As a result, the locally build rubygem and its locally installed executable works regardless that my~/.gitconfig
includes an entry ofCan you please have a look on this? To ease the revision by a second party, edits to each level are intentionally retained in its own commit.
Level 28/push however is somewhat odd. Because I can run
though the commits just prior to the
push
likely are not in the sequence the initial design of this question aims for. I would accept if I'm wrong on this point.I'm not yet comfortable to test the quizz of level 50 /
stage_lines
; however, because this is a git technique so far not used. It is a bit beyond resolving merge conflicts I usually resolve withgit mergetool
.