search

GazzolaLab / PyElastica

Python implementation of Elastica, an open-source software for the simulation of assemblies of slender, one-dimensional structures using Cosserat Rod theory.
https://www.cosseratrods.org
MIT License
221 stars 109 forks source link

Remove the option for internal damping module for Cosserat rods following warning message #194

Closed bhosale2 closed 1 year ago

bhosale2 commented 2 years ago

Currently, adding damping to the rod via AnalyticalLinearDamper results in the following warning message:

Screen Shot 2022-08-30 at 10 02 31 PM

Per the warning to make a soft change, we should convert the warning message to an error message if the user provides internal damping other than None when initializing a Cosserat rod, and remove related functionality from the cosserat rod equations.

Thoughts @armantekinalp and @skim0119?

armantekinalp commented 2 years ago

I agree with you suggestion. As we discussed with @bhosale2, I think we should remove the internal damping functionality, all variables and tests as we planned in v.0.3.1 and update the warning message accordingly.

bhosale2 commented 1 year ago

Closed via #243.