search

Gbuomprisco / ng2-expansion-panels

Expansion Panels component for Angular 2
18 stars 3 forks source link

ERROR in ExpansionPanelsModule is not an NgModule #5

Closed bendg25 closed 7 years ago

bendg25 commented 7 years ago

I keep getting this error intermittently and I cannot pin down why.

Any ideas?

Gbuomprisco commented 7 years ago

Hi @bendg25,

you're right, the Angular version was outdated when I build this. I will have a look at upgrading it soon.

bendg25 commented 7 years ago

Ok great,

If there is anything I can do to help, please let me know (as this is a blocker for me right now :)).

On 6 March 2017 at 08:32, Giancarlo Buomprisco notifications@github.com wrote:

Hi @bendg25 https://github.com/bendg25,

you're right, the Angular version was outdated when I build this. I will have a look at upgrading it soon.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gbuomprisco/ng2-expansion-panels/issues/5#issuecomment-284332646, or mute the thread https://github.com/notifications/unsubscribe-auth/AEGmXZyJdYWEs0qNCrpiIEoXDu6FEcrUks5ri8S6gaJpZM4MT1Ck .

-- Ben Gill Mobile: (07852) 219856 E-mail: ben.d.gill@gmail.com

Gbuomprisco commented 7 years ago

Hi @bendg25,

can you try version 0.0.3? Just released it :) I am getting it working with angular 2.4.9 (but won't have time to test with an external repo so sorry if it won't work)

bendg25 commented 7 years ago

Hi Giancarlo,

I just tried and I get the same error: ERROR in ExpansionPanelsModule is not an NgModule

webpack: Failed to compile.

(I upgraded to 2.4.9 also).

On 6 March 2017 at 08:57, Giancarlo Buomprisco notifications@github.com wrote:

Hi @bendg25 https://github.com/bendg25,

can you try version 0.0.3? Just released it :) I am getting it working with angular 2.4.9 (but won't have time to test with an external repo so sorry if it won't work)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gbuomprisco/ng2-expansion-panels/issues/5#issuecomment-284337627, or mute the thread https://github.com/notifications/unsubscribe-auth/AEGmXcUGHZPGhGWFcnQZmmcAesYlqqtsks5ri8qDgaJpZM4MT1Ck .

-- Ben Gill Mobile: (07852) 219856 E-mail: ben.d.gill@gmail.com

Gbuomprisco commented 7 years ago

Hmm I think this is due to the AOT config. You are trying to run it using AOT right? Angular-cli maybe?

bendg25 commented 7 years ago

Yes I am running through angular-cli

On 6 March 2017 at 09:16, Giancarlo Buomprisco notifications@github.com wrote:

Hmm I think this is due to the AOT config. You are trying to run it using AOT right? Angular-cli maybe?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gbuomprisco/ng2-expansion-panels/issues/5#issuecomment-284341903, or mute the thread https://github.com/notifications/unsubscribe-auth/AEGmXS5JZ5Wj8wPmzVDFyGwWU_qtEzPWks5ri88EgaJpZM4MT1Ck .

-- Ben Gill Mobile: (07852) 219856 E-mail: ben.d.gill@gmail.com

Gbuomprisco commented 7 years ago

Theoretically - if for the time being you disable AOT compilation, it should work. Unless you have production releases needs, it should be OK (again, in theory :|) :)

bendg25 commented 7 years ago

Ok thanks, I do have prod build requirements though :).

On Mon, 6 Mar 2017 at 09:27, Giancarlo Buomprisco notifications@github.com wrote:

Theoretically - if for the time being you disable AOT compilation, it should work. Unless you have production releases needs, it should be OK (again, in theory :|) :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gbuomprisco/ng2-expansion-panels/issues/5#issuecomment-284344557, or mute the thread https://github.com/notifications/unsubscribe-auth/AEGmXfqUWfor8nMtDoaGTokpdb5dyYMAks5ri9GTgaJpZM4MT1Ck .

-- Ben Gill Mobile: (07852) 219856 E-mail: ben.d.gill@gmail.com

bendg25 commented 7 years ago

Hi

I do still get

ERROR in ExpansionPanelsModule is not an NgModule

webpack: Failed to compile.

when running ng serve

On 6 March 2017 at 09:42, Ben Gill ben.d.gill@gmail.com wrote:

Ok thanks, I do have prod build requirements though :).

On Mon, 6 Mar 2017 at 09:27, Giancarlo Buomprisco < notifications@github.com> wrote:

Theoretically - if for the time being you disable AOT compilation, it should work. Unless you have production releases needs, it should be OK (again, in theory :|) :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gbuomprisco/ng2-expansion-panels/issues/5#issuecomment-284344557, or mute the thread https://github.com/notifications/unsubscribe-auth/AEGmXfqUWfor8nMtDoaGTokpdb5dyYMAks5ri9GTgaJpZM4MT1Ck .

-- Ben Gill Mobile: (07852) 219856 E-mail: ben.d.gill@gmail.com

-- Ben Gill Mobile: (07852) 219856 E-mail: ben.d.gill@gmail.com

functionportal commented 7 years ago

+1

bendg25 commented 7 years ago

How do we debug this issue? This is a blocker for me :)

On 14 March 2017 at 02:24, craftyInstigator notifications@github.com wrote:

+1

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gbuomprisco/ng2-expansion-panels/issues/5#issuecomment-286302761, or mute the thread https://github.com/notifications/unsubscribe-auth/AEGmXcyoZY8OO2jdRly7PM9zEEXuV1lCks5rlfpngaJpZM4MT1Ck .

-- Ben Gill Mobile: (07852) 219856 E-mail: ben.d.gill@gmail.com

pavelalexeenko commented 7 years ago

Having same issue, both with and without "-aot false" flag on ng build, ng serve (angular-cli)

Gbuomprisco commented 7 years ago

Hi, I will have a look during the weekend

pavelalexeenko commented 7 years ago

Hi @Gbuomprisco, any news?

Gbuomprisco commented 7 years ago

Hi everyone,

just released version 0.0.5 which should fix it. Tested with @angular/cli": "^1.0.0-beta.32.3

pavelalexeenko commented 7 years ago

@Gbuomprisco ng build goes fine, but still having errors with ng build -prod. @angular/cli 1.0.0-rc.2

ERROR in Child compilation failed:
Module not found: Error: Can't resolve './arrow_down.svg' in '~\node_modules\ng2-expansion-panels\dist\modules\components\e
xpansion-panel':
Error: Can't resolve './arrow_down.svg' in '~\node_modules\ng2-expansion-panels\dist\modules\components\expansion-panel'

ERROR in ./src/main.ts
Module not found: Error: Can't resolve './$$_gendir/app/app.module.ngfactory' in '~\src'
 @ ./src/main.ts 4:0-74
 @ multi ./src/main.ts
Gbuomprisco commented 7 years ago

possibly due to https://github.com/angular/angular-cli/issues/4806

Gbuomprisco commented 7 years ago

Hi @pavelalexeenko,

I removed the image and put the svg inside the template - now it should be OK

pavelalexeenko commented 7 years ago

@Gbuomprisco works fine now, thanks!

Gbuomprisco commented 7 years ago

Cool :)

bendg25 commented 7 years ago

Hi Giancarlo,

I am getting this error when trying to use 0.0.6:

http://localhost:4200/expansion-panels-container.template.html Failed to load resource: the server responded with a status of 404 (Not Found) polyfills.bundle.js:3900 Unhandled Promise rejection: Failed to load expansion-panels-container.template.html ; Zone: ; Task: Promise.then ; Value: Failed to load expansion-panels-container.template.html undefined consoleError @ polyfills.bundle.js:3900

On 20 March 2017 at 09:40, Giancarlo Buomprisco notifications@github.com wrote:

Closed #5 https://github.com/Gbuomprisco/ng2-expansion-panels/issues/5.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gbuomprisco/ng2-expansion-panels/issues/5#event-1006368765, or mute the thread https://github.com/notifications/unsubscribe-auth/AEGmXX1G4hxexLgniAGNJmdqY_4W1Tutks5rnkl1gaJpZM4MT1Ck .

-- Ben Gill Mobile: (07852) 219856 E-mail: ben.d.gill@gmail.com

Gbuomprisco commented 7 years ago

Hi @bendg25,

are you using SystemJS?

bendg25 commented 7 years ago

Hi Giancarlo,

No I am using webpack with angular cli. I used to use SystemJs on my project.

What do you think might have caused this?

Kind Regards

On 26 March 2017 at 13:54, Giancarlo Buomprisco notifications@github.com wrote:

Hi @bendg25 https://github.com/bendg25,

are you using SystemJS?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gbuomprisco/ng2-expansion-panels/issues/5#issuecomment-289281422, or mute the thread https://github.com/notifications/unsubscribe-auth/AEGmXSKGlfw6P2bQtuYl9eOMfwh3-RSLks5rpl_-gaJpZM4MT1Ck .

-- Ben Gill Mobile: (07852) 219856 E-mail: ben.d.gill@gmail.com

Gbuomprisco commented 7 years ago

I was asking as this sort of errors usually happens with SystemJS. But never encountered with the cli really :|