search

Gbuomprisco / ng2-material-dropdown

Angular 2 Material-like Dropdown Component
MIT License
37 stars 54 forks source link

It break AOT compilation #17

Closed daniele-zurico closed 7 years ago

daniele-zurico commented 7 years ago

as per title it break AOT compilation. The problem is related to:

    styles: [require('./style.scss').toString()],
    template: require('./template.html')
daniele-zurico commented 7 years ago

could you please have a look on the PR that I created? It fix the problem and now is AOT compliant

Gbuomprisco commented 7 years ago

Hi @daniele-zurico,

I merged your PR to develop - and I've tried to make it work but no luck so far. Getting the following error:

GET http://localhost:3005/template.html 404 (Not Found)scheduleTask @ zone.js:1263ZoneDelegate.scheduleTask @ zone.js:205Zone.scheduleMacroTask @ zone.js:142(anonymous function) @ zone.js:1293send @ VM4667:3ResourceLoaderImpl.get @ platform-browser-dynamic.umd.js:129DirectiveNormalizer._fetch @ compiler.umd.js:13455DirectiveNormalizer.normalizeTemplateAsync @ compiler.umd.js:13498DirectiveNormalizer.normalizeDirective @ compiler.umd.js:13473RuntimeCompiler._createCompiledTemplate @ compiler.umd.js:16869(anonymous function) @ compiler.umd.js:16807(anonymous function) @ compiler.umd.js:16805RuntimeCompiler._compileComponents @ compiler.umd.js:16804RuntimeCompiler._compileModuleAndComponents @ compiler.umd.js:16741RuntimeCompiler.compileModuleAsync @ compiler.umd.js:16732PlatformRef_._bootstrapModuleWithZone @ core.umd.js:6954PlatformRef_.bootstrapModule @ core.umd.js:6936(anonymous function) @ app.ts:15__webpack_require__ @ bootstrap 66fb09e0647f1ce62842:50(anonymous function) @ app.bundle.js:6__webpack_require__ @ bootstrap 66fb09e0647f1ce62842:50webpackJsonpCallback @ bootstrap 66fb09e0647f1ce62842:21(anonymous function) @ app.bundle.js:1
zone.js:344 Unhandled Promise rejection: Failed to load template.html ; Zone: <root> ; Task: Promise.then ; Value: Failed to load template.html undefinedconsoleError @ zone.js:344_loop_1 @ zone.js:371drainMicroTaskQueue @ zone.js:375ZoneTask.invoke @ zone.js:297
zone.js:346 Error: Uncaught (in promise): Failed to load template.html(…)

Did you make it work locally?Thanks for the PR

daniele-zurico commented 7 years ago

Yes I got working locally but I did a lot of changes on it so I decided to include as component in my core api. If you give me an email address I can compress and send to you. I think that you did also the other library called ng2-select or something like that. I modified that one as well and I can send you both.

daniele-zurico commented 7 years ago

By the way now that I'm looking the simple change that I did should be enough to have it working. The error that you receive is when you compile in AOT mode or normally?

Gbuomprisco commented 7 years ago

I'm trying to run it normally - it seems awesome-ts-loader might be the issue

daniele-zurico commented 7 years ago

I'll have a look tomorrow and I'll create a repro for you.

Gbuomprisco commented 7 years ago

Very cool, thanks @daniele-zurico!