search

Gbuomprisco / ng2-material-dropdown

Angular 2 Material-like Dropdown Component
MIT License
37 stars 54 forks source link

Fix hardcoded menu item hierarchy #33

Open iperevozchikov opened 7 years ago

iperevozchikov commented 7 years ago

Added descendants option to make possible inject own dom-elements between ng2-dropdown-menu and ng2-menu-item components.

iperevozchikov commented 7 years ago

@Gbuomprisco

Hi! May you review request? Unfortunately i can't start to make "pull request" for support virtualscroll in ngx-chips without these changes (https://github.com/Gbuomprisco/ngx-chips/issues/457#issuecomment-310976182)

Gbuomprisco commented 7 years ago

I'll do that asap

iperevozchikov commented 7 years ago

@Gbuomprisco Thanks!

Gbuomprisco commented 7 years ago

sorry @iperevozchikov i just noticed the tests failed :( though it should not be related to the fix

Gbuomprisco commented 7 years ago

Hi @iperevozchikov,

also noticed that all compiled files have been checked in. Only changed to the source code need to be checked :)

iperevozchikov commented 6 years ago

Hi @Gbuomprisco , I have a some free time to fix my pull request =) Can you review it? Tests now seems as passed.

Gbuomprisco commented 6 years ago

Hi @iperevozchikov,

thanks again for the PR. Unfortunately I still see a lot of compilation related files checked in, just make sure only the source code will be added to the repo :)