Closed rrfenton closed 7 years ago
Hi @rrfenton,
are you using disableDebugTools
anywhere?
I am not, as that would cause the whole app to break, no matter which version of the ng2-tag-input module I was using.
By reading here https://github.com/qdouble/angular-webpack2-starter/issues/263 and here https://medium.com/@gerasimov.pk/angular-4-rc-5-review-fe168b04ffe9 looks like that would be the issue. I'll let you know if I find anything.
@Gbuomprisco I have looked into both these solutions and have determined these to not be the core cause.
As I said in the main post, this problem occurs after upgrading from 0.9.10 of ng2-tag-input to version 1.0.1. Both my core application, and my tests work fine when on 0.9.10 (minus some warning regarding ng-template in the ng2-tag-input codebase).
Because of this peculiarity, I can only assume it's not an issue with my codebase, as the only commonality for this issue are modules where ng2-tag-input@1.0.1 are imported.
EDIT: I also want to add, in the case of the core code, the animations package is being loaded at a root level module scope.
Right now I have no idea what that error could be about. I'd suggest you to revert to the previous version if it works
I am also having the same issue:
27 03 2017 14:27:52.535:INFO [karma]: Karma v1.5.0 server started at http://0.0.0.0:9876/
27 03 2017 14:27:52.537:INFO [launcher]: Launching browser Chrome with unlimited concurrency
27 03 2017 14:27:52.544:INFO [launcher]: Starting browser Chrome
27 03 2017 14:27:53.482:INFO [Chrome 57.0.2987 (Mac OS X 10.12.3)]: Connected on socket jZm2nju6Do4C399LAAAA with id 18851526
Chrome 57.0.2987 (Mac OS X 10.12.3) TagInputComponent Basic behaviours should have 2 tags set by ngModel FAILED
TypeError: Cannot read property 'setGlobalVar' of null
at _createNgProbe (spec-bundle.js:9:3406677)
at DynamicTestModuleInjector.createInternal (ng:///DynamicTestModule/module.ngfactory.js:207:5)
at DynamicTestModuleInjector.NgModuleInjector.create (spec-bundle.js:9:164127)
at NgModuleFactory.create (spec-bundle.js:9:162854)
at TestBed._initIfNeeded (spec-bundle.js:9:1298533)
at TestBed.createComponent (spec-bundle.js:9:1304808)
at Function.TestBed.createComponent (spec-bundle.js:9:1291594)
at Object.
It started happening when I upgraded to Angular 4.
It works with the ng2-tag-input@1.0.0
Same here. Ng-4.0.0 tag-input 1.0.1.
Also getting some warnings around template syntax, but that's another issue.
Can also confirm 1.0.0 works with ng-4.0.0.
I have the same issue with Angular 4.0.0 and "ng2-tag-input": "1.0.1" 1.0.0 works good.
Hi everyone - can anyone try ng2-tag-input@1.0.2?
I removed the animations module as I assume it should only be imported in the root - but am usure whether it was the actual issue?
It is working. Thanks. I had to import the BrowserAnimationsModule in the root module, so I think it should be added to the readme.
true - i'll update the doc
@Gbuomprisco 1.0.2 works good (with imported BrowserAnimationsModule in app.module), thanks!
Closing this :) please reopen if still an issue for anyone
I'm submitting a ... (check one with "x")
Current behavior On version 1.0.1, whenever the ng2-tag-input module is loaded, I'm getting the following error:
This error is occurring in the core codebase, as well as when trying to inject ng2-tag-input in any tests.
This was not occurring as of the previous version I was using (0.9.10)
Expected behavior The module loads correctly.
Minimal reproduction of the problem with instructions Create a module that imports ng2-tag-input, either in tests or in code.
Here is an example module that is failing:
Here is an example of an import in a test that is failing:
What do you use to build your app? (SystemJS, Webpack). Please specify the version Using 1.0.0 of the angular-cli tool (webpack)
Angular version: 4.0.0
Browser: Chrome and PhantomJS