ahmagdy commented 6 years ago

In version 1.9.6 there is a build problem when you use the package in any project

"ERROR in node_modules/ngx-chips/core/accessor.d.ts(2,34): error TS2307: Cannot find module '../../modules/components/dropdown/tag-input-dropdown.component'."

This change in the TagInputDropdown path should fix the build problem, i tried it locally and it works.

codecov[bot] commented 6 years ago

Codecov Report

Merging #808 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #808   +/-   ##
======================================
  Coverage    67.2%   67.2%           
======================================
  Files          15      15           
  Lines         744     744           
  Branches      127     127           
======================================
  Hits          500     500           
  Misses        188     188           
  Partials       56      56

Impacted Files	Coverage Δ
modules/core/accessor.ts	`92.85% <ø> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4d0ff72...097d6f2. Read the comment docs.

junaidahmed501 commented 6 years ago

@Ahmad-Magdy thanks Ahmad, this last commit regarding TagInputDropdown path made my day, cheers

ahmagdy commented 6 years ago

You're welcome @junaidahmed501
Happy to help :)

Gbuomprisco / ngx-chips

fix the path of TagInputDropDown Component #808

Codecov Report