support for Angular8 - Githubissues

Gbuomprisco / ngx-chips

Tag Input component for Angular

MIT License

902 stars 359 forks source link

support for Angular8 #876

Closed Marcelh1983 closed 5 years ago

Marcelh1983 commented 5 years ago

I upgraded to Angular8 and upgraded all packages.

ContentChilds should have the static option static. I made them false which is the new default, therefore I had to change ngOnInit to ngAfterViewinit https://angular.io/guide/static-query-migration
I used the build of the demo app, test and code coverage. Just because I know how that works.
No lint erros, all tests succeed, demo app seems to work fine.

Gbuomprisco commented 5 years ago

Hey @Marcelh1983, thanks for the huge PR! For some reason, the CI never got triggered and as a result I cannot merge. Maybe you could try triggering another build?

Gbuomprisco commented 5 years ago

Ok I see, the file .travis.yml got deleted, it should be restored :)

Marcelh1983 commented 5 years ago

@Gbuomprisco thanks for merging. I was stupid to delete the .travis.yml.