search

Gbuomprisco / ngx-chips

Tag Input component for Angular
MIT License
899 stars 359 forks source link

Bump peerDependency of Angular to ^10 #950

Closed bjornharvold closed 3 years ago

bjornharvold commented 4 years ago

I'm submitting a ... (check one with "x")

[ ] bug report => search github for a similar issue or PR before submitting
[x ] support request/question

Notice: feature requests will be ignored, submit a PR if you'd like

Current behavior

When running an ng update @angular/core it fails because ngx-chips has outdated peer dependencies. To bypass this, a developer would have to --force the update. Shouldn't be necessary.

ngx-chips" has an incompatible peer dependency to "@angular/animations" (requires "^8.0.0" (extended), would install "10.0.0")

Expected behavior

ngx-chips project should always use the latest peerDependency of Angular that it supports. ng update should work without having to --force the update.

Minimal reproduction of the problem with instructions (if applicable) ng update @angular/core @angular/cli

What do you use to build your app?. Please specify the version Angular CLI

Angular version: Angular 10

ngx-chips version: Yes

elvispdosreis commented 4 years ago

is an excellent component, awaiting support at Angular10

akamal88 commented 4 years ago

yes, i wish they support angular 10

armved commented 4 years ago

Guys, is there any progress with adding support of Angular 10? This stops lot of projects from upgrading Angular version

akamal88 commented 4 years ago

I create PR to fix this, but the owner of the project didn't reply, so, i created a clone that has this fix npm install ngx-chips-angular

akamal88 commented 3 years ago

Thanks @Gbuomprisco for merging the PR, the new version is alive in npm package

Gbuomprisco commented 3 years ago

Thank you for the PR :) @akamal88