search

Gcenx / WineskinServer

Wineskin
GNU Lesser General Public License v2.1
2.42k stars 167 forks source link

WS11WineCX64Bit23.0.1-wip3 breaks existing wrapper #467

Closed emendelson closed 9 months ago

emendelson commented 9 months ago

Environment (please complete the following information):

Describe the bug When I try to update this wrapper from 23.0.1-wip to 23.0.1-wip3, Wineskin locks up.

To Reproduce Download the app linked above. Reveal package contents Find the wrapper inside the app; reveal package contents Run Wineskin; try to update the engine to 23.0.1-wip3

Expected behavior The engine updates and the wrapper runs

Screenshots

LastRunWine.log

preloader: Warning: failed to reserve range 0000000000010000-0000000000110000
dyld[24079]: Library not loaded: /opt/local/lib/libinotify.0.dylib
  Referenced from: <A10D495F-B442-3DDF-9D9C-E090DFCE6F54> /Users/edward/Desktop/WordPerfect for Windows copy 2.app/Contents/Resources/WordPerfect X3.app/Contents/SharedSupport/wine/bin/wineserver
  Reason: tried: '/opt/local/lib/libinotify.0.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/opt/local/lib/libinotify.0.dylib' (no such file), '/opt/local/lib/libinotify.0.dylib' (no such file), '/Users/edward/Desktop/WordPerfect for Windows copy 2.app/Contents/Resources/WordPerfect X3.app/Contents/SharedSupport/wine/lib/libinotify.0.dylib' (no such file), '/Users/edward/Desktop/WordPerfect for Windows copy 2.app/Contents/Resources/WordPerfect X3.app/Contents/SharedSupport/wine/lib64/libinotify.0.dylib' (no such file), '/Users/edward/Desktop/WordPerfect for Windows copy 2.app/Contents/Resources/WordPerfect X3.app/Contents/SharedSupport/wine/lib32on64/libinotify.0.dylib' (no such file), '/Users/edward/Library/Application Support/Wineskin/Runtime/libinotify.0.dylib' (no such file), '/Users/edward/Desktop/WordPerfect for Windows copy 2.app/Contents/Resources/WordPerfect X3.app/Contents/Frameworks/libinotify.0.dylib' (no such file), '/usr/lib/libinotify.0.dylib' (no such file, not in dyld cache), '/usr/libexec/libinotify.0.dylib' (no such file), '/usr/lib/system/libinotify.0.dylib' (no such file, not in dyld cache), '/opt/X11/lib/libinotify.0.dylib' (no such file)

Additional context The log refers to libnotify in the location /opt/local/lib. This is the location used by brew on Intel Macs. I'm running an arm64 Mac, which uses a different location, and I have no idea whether this is relevant or not.

Gcenx commented 9 months ago

/opt/local/lib this path is macports

/usr/local/lib this path is Intel brew

But the library it’s looking for it’s not in the current master wrapper I’ll need to do a wrapper update.

emendelson commented 9 months ago

Of course you're right... Ever since I started using an M2 Mac, I forgot the old Intel-based paths...

Gcenx commented 9 months ago

Let’s keep this open for now until I’ve pushed a new master wrapper that bundles this dylib

Gcenx commented 9 months ago

This should now be resolved via https://github.com/Gcenx/WineskinServer/commit/daeb4ddf1525964b4ed50b64b9f229db556a6f4e

emendelson commented 9 months ago

Thank you!

EDIT: Something is still wrong, I think. When I update the wrapper in a working setup, the Windows program doesn't run at all. Here's a log:

0104:trace:loaddll:build_module Loaded L"C:\\Program Files (x86)\\Microsoft Expression\\Web 4\\ExpressionWeb.exe" at 0000000045000000: native
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\wow64.dll" at 000000006F000000: builtin
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\wow64cpu.dll" at 000000006F100000: builtin
0104:trace:loaddll:build_module Loaded L"C:\\Program Files (x86)\\Microsoft Expression\\Web 4\\ExpressionWeb.exe" at 45000000: native
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\kernelbase.dll" at 7B000000: builtin
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\kernel32.dll" at 7B600000: builtin
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\mscoree.dll" at 79000000: native
0104:fixme:ntdll:NtQuerySystemInformation info_class SYSTEM_PERFORMANCE_INFORMATION
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\msvcrt.dll" at 00C30000: builtin
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\ucrtbase.dll" at 00CD0000: builtin
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\sechost.dll" at 6BC00000: builtin
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\ADVAPI32.dll" at 61740000: builtin
0104:trace:loaddll:build_module Loaded L"C:\\windows\\Microsoft.NET\\Framework\\v4.0.30319\\mscoreei.dll" at 603B0000: native
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\version.dll" at 63480000: builtin
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\win32u.dll" at 6B0B0000: builtin
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\user32.dll" at 6ED00000: builtin
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\GDI32.dll" at 6C9C0000: builtin
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\SHLWAPI.dll" at 01200000: native
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\imm32.dll" at 01490000: builtin
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\MSVCR100_CLR0400.dll" at 79060000: native
0104:trace:loaddll:build_module Loaded L"C:\\windows\\Microsoft.NET\\Framework\\v4.0.30319\\clr.dll" at 79140000: native
0104:fixme:thread:get_thread_times not implemented on this platform
0104:fixme:seh:WerRegisterRuntimeExceptionModule (L"C:\\windows\\Microsoft.NET\\Framework\\v4.0.30319\\mscordacwks.dll", 79140000) stub
0104:fixme:nls:CompareStringEx semi-stub behavior for flag(s) 0x10000000
0104:trace:loaddll:build_module Loaded L"C:\\windows\\assembly\\NativeImages_v4.0.30319_32\\mscorlib\\ed638f8fbb4f1fd72c208ebe9caa4de6\\mscorlib.ni.dll" at 79880000: native
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\rpcrt4.dll" at 62FC0000: builtin
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\combase.dll" at 04010000: builtin
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\ole32.dll" at 03EF0000: builtin
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\winemac.drv" at 6B250000: builtin
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\uxtheme.dll" at 040A0000: builtin
010c:err:ole:CoGetContextToken apartment not initialised
0104:trace:loaddll:build_module Loaded L"C:\\windows\\Microsoft.NET\\Framework\\v4.0.30319\\nlssorting.dll" at 60930000: native
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\bcrypt.dll" at 66240000: builtin
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\crypt32.dll" at 04B00000: builtin
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\rsaenh.dll" at 6FE40000: builtin
0104:trace:loaddll:build_module Loaded L"C:\\windows\\Microsoft.NET\\Framework\\v4.0.30319\\clrjit.dll" at 79810000: native
0104:trace:loaddll:build_module Loaded L"C:\\windows\\assembly\\NativeImages_v4.0.30319_32\\System\\af5ee178b564c4daeac9b8092cf8af36\\System.ni.dll" at 04BE0000: native
0104:trace:loaddll:build_module Loaded L"C:\\windows\\assembly\\NativeImages_v4.0.30319_32\\WindowsBase\\c4da32b0ee69c1bdddd0192883790b3a\\WindowsBase.ni.dll" at 58C20000: native
0104:fixme:nls:get_dummy_preferred_ui_language (0x0 0012E610 00000000 0012E60C) returning a dummy value (current locale)
0104:fixme:nls:get_dummy_preferred_ui_language (0x0 0012E610 004EEEB0 0012E60C) returning a dummy value (current locale)
0104:fixme:nls:ResolveLocaleName stub: L"en", 0012F140, 85
0104:fixme:nls:ResolveLocaleName stub: L"en", 0012F0B8, 85
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\oleaut32.dll" at 64EC0000: builtin
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\propsys.dll" at 054F0000: builtin
0104:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\WindowsCodecs.dll" at 62D40000: builtin
emendelson commented 9 months ago

To continue: I'm getting inconsistent results. One updated wrapper works perfectly. Another doesn't start at all, and I have to shut down all the processes in Activity Manager. A third runs Wineskin when I launch the wrapper, instead of the program itself. I wish I could figure out a pattern.

Gcenx commented 9 months ago

I hope your not updating existing wrappers to the newer wip engines.

I’d only generate new wrappers with the wip engine are these don’t have all patchsets rebased into the branch yet and lightly wont until CX23.5.0 sources lands.

emendelson commented 9 months ago

Yeah - that's what I've been doing, with the idea that they new versions might be faster. But there's no REAL reason for me to do this, so I'll stop! Thanks for the explanation.

Gcenx commented 9 months ago

My rule of thumb is if an existing wrapper is still working I won’t touch it.

emendelson commented 9 months ago

That's what I should have been doing all along...