Gcenx / macOS_Wine_builds

Official Winehq macOS Packages
511 stars 23 forks source link

wine-9.21: Removed the releases as they failed at wineboot #114

Closed Gcenx closed 1 day ago

Gcenx commented 3 days ago

Not sure if the problem is upstream or some of the applied patches.

1146839821 commented 3 days ago

I applied the msync patch (1001 develop msync. diff), which can cause compilation issues completion.c:95:5: error: incompatible function pointer types initializing 'unsigned int (*)(struct object *, enum msync_type *)' with an expression of type 'void (struct object *, struct wait_queue_entry *)' [-Wincompatible-function-pointer-types] 95 | completion_wait_satisfied, /* satisfied */

edit:It's interesting that sometimes it's just a warning,but wineboot failed. wineserver crashed, please enable coredumps (ulimit -c unlimited) and restart.

oscarbg commented 3 days ago

sad.. was going to test now.. hope not my patches or dxmt.. want to test both..

Gcenx commented 3 days ago

@1146839821 I’ve already contacted @marzent about this, while I could bypass this compilation error wineserver became broken.

I’ll be holding off on providing a release until ether marzent or myself have managed to fix the msync patchset.

I’ve updated macports-wine accordingly with a revision bump with msync disabled.

Gcenx commented 3 days ago

sad.. was going to test now.. hope not my patches or dxmt.. want to test both..

@oscarbg the wineserver problem was caused by msync, the DXMT exports won’t have caused any issues as it’s a simple change to visibility and the other two shouldn’t cause any problems.

oscarbg commented 3 days ago

nice.. would try https://github.com/Gcenx/macports-wine in the meanwhile, but question? it supports dxmt? and my two patches? seems not as patches not included there: https://github.com/Gcenx/macports-wine/tree/main/emulators/wine-devel/files EDIT: to clarify, I'm not asking to include patches there.. as seems more of a vanilla build..

Gcenx commented 3 days ago

@oscarbg the additional patches were committed to my person overlay not macports-wine, you could easily add them to the overlay locally then build the desired package.

Gcenx commented 2 days ago

Current progress

oscarbg commented 2 days ago

nice.. makes sense, to provide a wine-devel package then?, until staging gets fixed?

Gcenx commented 1 day ago

https://github.com/Gcenx/macOS_Wine_builds/releases/tag/9.21

@oscarbg these also contain the requested patches.