Gcenx / macOS_Wine_builds

Official Winehq macOS Packages
461 stars 23 forks source link

Build with epoll-shim #40

Closed FlyGoat closed 1 year ago

FlyGoat commented 1 year ago

Hi,

Currently wine executable complains:

00dc:fixme:esync:do_esync eventfd not supported on this platform.

This can be easily fixed by building wine with epoll-shim, which emulates EventFD with kqueue.

Ref: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246426

Thanks.

Gcenx commented 1 year ago

I’ve reached out to my fellow maintainer and they believe well first need to verify if adding this gives any benefit over just removing the fixme.

Waiting to hear back from the staging maintainers for possible test cases to see if there’s really any improvement by adding this.

The simply solution is to skip applying the eventfd_synchronization patchset.

Gcenx commented 1 year ago

I’ve attempted this and esync starts up then companies about an invalid command 20

Guess I’ll go with simply disabling the patchset as planned.

Gcenx commented 1 year ago

Here's the result of attempting to make use of epoll-shim

gcenx@Deans-Mac-mini ~ % export WINEESYNC=1
gcenx@Deans-Mac-mini ~ % wine64 explorer   
esync: up and running.
Protocol error: process 0020: sendmsg: Invalid argument

So unless Zeb feels like modifying eventfd_synchronization patchset to work with epoll-shim I'll just be skipping the patchset going forward.