Closed smt5541 closed 2 months ago
I think to resolve current conflicts we can just take this branch version as source of truth?
I think to resolve current conflicts we can just take this branch version as source of truth?
Eh, mostly - some indentations introduced in other PRs made it a little messier, but that's all set now
Btw love the added pypi classifiers on this, should help with project visibility 👍
🛠 Changes being made
Give examples of the changes you've made in this pull request. Include an itemized list if you can.
ValidateParameters#__call__
andValidateParameters#validate
to supportlist
alongside the existing support fortyping.List
setup.py
to add supported version information and additional PyPI classifiers🧠 Rationale behind the change
Why did you choose to make these changes?
Reading through the
typing
documentation, I noticed thattyping.List
was deprecated as of Python 3.9. Since this library currently targets Python 3.9 at a minimum per some of its dependencies, it seems this would be a fitting changeDoes this pull request resolve any open issues?
Closes #48
Were there any trade-offs you had to consider?
I had to ensure that our minimum supported Python version would not be changed by implementing this support. Our dependencies pin us to a minimum of Python 3.9, so it seems we remain at that level.
🧪 Testing
[X] Have tests been added or updated for the changes introduced in this pull request?
[X] Are the changes backwards compatible?
If the changes aren't backwards compatible, what other options were explored?
✨ Quality check
[X] Are your changes free of any erroneous print statements, debuggers or other leftover code?
[X] Has the README been updated to reflect the changes introduced (if applicable)?
💬 Additional comments
Feel free to add any further information below
Depends on #45