Ge0rg3 / flask-parameter-validation

Get and validate all Flask input parameters with ease.
https://pypi.org/project/Flask-Parameter-Validation/
28 stars 12 forks source link

Add support for standard list type hints #50

Closed smt5541 closed 2 months ago

smt5541 commented 2 months ago

🛠 Changes being made

Give examples of the changes you've made in this pull request. Include an itemized list if you can.

🧠 Rationale behind the change

Why did you choose to make these changes?

Reading through the typing documentation, I noticed that typing.List was deprecated as of Python 3.9. Since this library currently targets Python 3.9 at a minimum per some of its dependencies, it seems this would be a fitting change

Does this pull request resolve any open issues?

Closes #48

Were there any trade-offs you had to consider?

I had to ensure that our minimum supported Python version would not be changed by implementing this support. Our dependencies pin us to a minimum of Python 3.9, so it seems we remain at that level.

🧪 Testing

If the changes aren't backwards compatible, what other options were explored?

✨ Quality check

💬 Additional comments

Feel free to add any further information below

Depends on #45

Ge0rg3 commented 2 months ago

I think to resolve current conflicts we can just take this branch version as source of truth?

smt5541 commented 2 months ago

I think to resolve current conflicts we can just take this branch version as source of truth?

Eh, mostly - some indentations introduced in other PRs made it a little messier, but that's all set now

Ge0rg3 commented 2 months ago

Btw love the added pypi classifiers on this, should help with project visibility 👍