nus-se-bot
commented
3 years ago Team's Response
It will rarely be the case that the user input an invalid date such as Feb 30th or Feb 31th.
More often, they will get the data from other files such as the csv input which could be obtained from other existing app such as Safe entry data. The safe entry data would already provide the visit record of the correct date, unless you can justify the app that the government is using currently have this major bug that can flip the dates. Otherwise, if the user manually input one visit to the visit list, the user should have checked for the date they entered.
Also upon successfully adding the visit, all the information relevant to this visit will be reflected on the panel below for user to check. They could also see the newly added visit card where the date can be clearly seen. In reality, this will rarely be the case that the user are careless or irrational, and also forget to check whether they have added successfully with the correct information.
But still I agree with you that we could remind the user when this extreme and rare case appears. But when the user accidentally forgot what the Feburary dates end with, our app also manage to assist the user by changing it to the last date of Feb and this is justified by java.
Items for the Tester to Verify
:question: Issue severity
Team chose [severity.Low]
Originally [severity.High]
- [ ] I disagree
Reason for disagreement: [replace this with your reason]
Upon entering this command,
I was greeted with this in response, which is the not what I entered.
This happened for several of such invalid dates, they seemd to be "rounded off" to the correct date.